Skip to content

fix(ci): bring plugin version values up to match default dynamic plugins#4153

Merged
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:mainfrom
jrichter1:ci-plugin-versions
Mar 12, 2026
Merged

fix(ci): bring plugin version values up to match default dynamic plugins#4153
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:mainfrom
jrichter1:ci-plugin-versions

Conversation

@jrichter1
Copy link
Copy Markdown
Member

Description

updates oci plugin versions in CI value files up to the same as in default dynamic plugins config

hopefully, it will fix the duplicate config errors in some of the jobs

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from rm3l and zdrapela February 2, 2026 10:56
@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-osd-gcp-helm-nightly

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-gke-helm-nightly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-gke-helm-nightly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

🚫 Image Push Skipped.

The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

🚫 Image Push Skipped.

The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image)

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-gke-helm-nightly

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-osd-gcp-helm-nightly

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-osd-gcp-operator-nightly

disabled: false
# Enable orchestrator plugins - Official release (Backstage 1.45.3)
- package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.1.0!red-hat-developer-hub-backstage-plugin-orchestrator"
- package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.4.0!red-hat-developer-hub-backstage-plugin-orchestrator"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.4.0!red-hat-developer-hub-backstage-plugin-orchestrator"
- package: 'oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:{{inherit}}'

How about inheriting the version from the dynamic-plugins.default.yaml ? This {{inherit}} option was added in 1.9.0 (see https://issues.redhat.com/browse/RHIDP-8215) and I think it may help reduce the burden with these versions..

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really neat, lets try that

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-osd-gcp-helm-nightly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

url: http://sonataflow-platform-data-index-service

- package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:bs_1.45.3__1.2.0!red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets"
- package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:{{inherit}}!red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets"
Copy link
Copy Markdown
Member

@rm3l rm3l Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why the Orchestrator plugins are defined here under global.dynamic.plugins and not under orchestrator.plugins..
See my similar comment in #4186 (comment)
Once redhat-developer/rhdh-chart#307 is merged, you may even be able to just unset orchestrator.plugins from the values files here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, nvm. As pointed out in #4186 (comment), it seems that the dynamic plugins definition in the values.yaml is used for both Helm and Operator deployments (which is a bit confusing IMO).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more point for separating the dynamic plugins from values.yaml to a ConfigMap

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jrichter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-osd-gcp-helm-nightly

@rhdh-qodo-merge
Copy link
Copy Markdown

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

🚫 Image Push Skipped.

The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image)

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@zdrapela
Copy link
Copy Markdown
Member

zdrapela commented Mar 5, 2026

How is it going with this PR @jrichter1?
This issue is related: https://issues.redhat.com/browse/RHDHBUGS-2652

@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

Signed-off-by: Jan Richter <jrichter@redhat.com>
@jrichter1 jrichter1 force-pushed the ci-plugin-versions branch from 923ce22 to b4dac40 Compare March 11, 2026 12:41
@github-actions
Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

Signed-off-by: Jan Richter <jrichter@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@jrichter1
Copy link
Copy Markdown
Member Author

/test e2e-osd-gcp-helm-nightly

@zdrapela
Copy link
Copy Markdown
Member

/test e2e-eks-helm-nightly

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 11, 2026

@jrichter1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-helm-nightly 9115513 link false /test e2e-gke-helm-nightly
ci/prow/e2e-eks-helm-nightly fe71543 link false /test e2e-eks-helm-nightly
ci/prow/e2e-osd-gcp-helm-nightly fe71543 link false /test e2e-osd-gcp-helm-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Member

@zdrapela zdrapela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, and sources are aligned with the references in the plugin catalog. Thank you!

@openshift-ci openshift-ci Bot added the lgtm label Mar 12, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit ba8b9ec into redhat-developer:main Mar 12, 2026
15 of 17 checks passed
# Scorecard - test ignored
# Test file: e2e-tests/playwright/e2e/plugins/scorecard/scorecard.spec.ts
- package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:pr_1499__0.1.0!red-hat-developer-hub-backstage-plugin-scorecard
- package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:bs_1.45.3__2.3.5!red-hat-developer-hub-backstage-plugin-scorecard
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:bs_1.45.3__2.3.5!red-hat-developer-hub-backstage-plugin-scorecard
- package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:bs_1.45.3__2.3.5

Just discussed with Armel and Gennady, that it's safer for E2E tests to skip the exclamation mark in plugin definitions for now. You can try that for the cherry pick.
It specifies the directory inside the OCI image (to allow having more plugins in one image). If the folder name is the same as the plugin name, it can be safely skipped. We actually always have only one plugin per image so far.

jrichter1 added a commit to jrichter1/rhdh that referenced this pull request Mar 12, 2026
…ins (redhat-developer#4153)

* fix(ci): inherit plugin versions for showcase value files

Signed-off-by: Jan Richter <jrichter@redhat.com>

* inherit plugins in showcase diff

Signed-off-by: Jan Richter <jrichter@redhat.com>

---------

Signed-off-by: Jan Richter <jrichter@redhat.com>
zdrapela pushed a commit to zdrapela/rhdh that referenced this pull request Mar 16, 2026
…ins (redhat-developer#4153)

* fix(ci): inherit plugin versions for showcase value files

Signed-off-by: Jan Richter <jrichter@redhat.com>

* inherit plugins in showcase diff

Signed-off-by: Jan Richter <jrichter@redhat.com>

---------

Signed-off-by: Jan Richter <jrichter@redhat.com>
openshift-merge-bot Bot pushed a commit that referenced this pull request Mar 16, 2026
…ins (#4153) (#4396)

* fix(ci): inherit plugin versions for showcase value files



* inherit plugins in showcase diff



---------

Signed-off-by: Jan Richter <jrichter@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants